Repository navigation
fix oob read in getSpelling when node has no ext tokens - #8907
Merged
danmar merged 2 commits intoOct 10, 2026
Merged
Conversation
danmar
reviewed
Oct 1, 2026
|
Test results for commit 9781751 (tools/test-my-pr.py, main compared to this PR): Test: http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8907/ Posted automatically by the cppcheck PR test runner. +N: warnings only with this PR, -N: warnings only with main. The AI review is written by Claude and can be wrong. |
chrchr-github
pushed a commit
to chrchr-github/cppcheck
that referenced
this pull request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSpelling() sets typeIndex to mExtTokens.size() - 1 and, for node types other than the FunctionDecl and DeclRefExpr branches, reads mExtTokens[typeIndex - 1] without the typeIndex <= 0 check those two branches already apply. A clang AST dump whose node line carries no ext tokens leaves typeIndex at 0 or -1 (size() - 1 wraps into the int), so the read goes out of bounds, which ASAN flags as a SEGV while importing the dump via --clang. Hoist the existing guard ahead of the index so it covers every node type.